Redo wait() API. #88
Redo wait() API. #88
Conversation
|
@cpuguy83 can you take a look? |
|
Thanks for taking a look! I'm not sure I understand how this changes the interfaces/call structure. |
Well, the idea is just that the shims don't need to understand how the thread management should be done, because that's handled by the wrapper -- I understood that was what the original issue was after. Can you elaborate a bit what kind of API you would like to see and I can take another shot at this. :-) |
| Wait { tx: sender } | ||
| } | ||
|
|
||
| pub fn wait_for_exit_code(&self, exit_code: Arc<ExitCode>) -> Result<(), Error> { |
There was a problem hiding this comment.
It's not clear that this function does not block.
Naming is hard and I can't think of a good one right now.
Maybe just a doc string would suffice.
| fn wait(&self, waiter: &Wait) -> Result<(), Error>; | ||
| } | ||
|
|
||
| pub struct Wait { |
There was a problem hiding this comment.
Can you add docs for all these public type/functions?
There was a problem hiding this comment.
I added docs and also tried to think of a better name for the function.
|
@ipuustin Ok yes I totally just brain farted on this yesterday. |
|
~might want to update the Line 41 in fff5901 |
|
Looks like this needs a rebase. |
The idea is that the shim implementations would need to do less thread management. Signed-off-by: Ismo Puustinen <[email protected]>
The idea is that the shim implementations would need to do less thread management.
Fixes: #67
@cpuguy83 would this approach make sense? It should maybe be part of a wider API change if it is needed.