Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Do not create empty archives #86

Merged
merged 1 commit into from
May 9, 2023

Conversation

cpuguy83
Copy link
Member

@cpuguy83 cpuguy83 commented Mar 7, 2023

When there are no binary artifacts we should not be generating tarballs since they will just be empty.

Closes #109

Dockerfile Outdated Show resolved Hide resolved
When there are no binary artifacts we should not be generating tarballs
since they will just be empty.

Signed-off-by: Brian Goff <[email protected]>
Copy link
Contributor

@ipuustin ipuustin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Mossaka Mossaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Mossaka Mossaka merged commit d2d2272 into containerd:main May 9, 2023
5 checks passed
@cpuguy83 cpuguy83 deleted the fix_release_tar_no_bin branch May 9, 2023 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tar.gz files included in releases are empty
3 participants