feat(bench): Re-enable cargo bench
#612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The benchmarking in the CI finishes in 23 minutes. FWIW @jsturtevant |
jsturtevant
reviewed
Jun 10, 2024
jsturtevant
reviewed
Jun 10, 2024
jsturtevant
reviewed
Jun 10, 2024
jsturtevant
reviewed
Jun 10, 2024
benches/containerd-shim-benchmarks/benches/webassembly-benchmarks.rs
Outdated
Show resolved
Hide resolved
jsturtevant
reviewed
Jun 12, 2024
Mossaka
force-pushed
the
renable-bench
branch
2 times, most recently
from
fad7e37
to
bae8997
Compare
jprendes
previously approved these changes
Jun 13, 2024
This commit reverts back a change made by commit SHA 6882dd5 and fixed all the build errors for the benchmark. Closes containerd#611 Signed-off-by: jiaxiao zhou <[email protected]>
this commit adds a new github action that runs every Sunday to measure the benchmark Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
jsturtevant
previously approved these changes
Jun 13, 2024
| wasi.delete()?; | ||
| res | ||
| fn run_wasmtime_test_with_spec(wasmbytes: &[u8]) -> Result<u32, Error> { | ||
| let (exit_code, _, _) = WasiTest::<WasmtimeTestInstance>::builder()? |
There was a problem hiding this comment.
Just a note that this test framework doesn't test starting containers in with containerd. One of the things we are interested in is the entire startup time including interactions with containerd and should make sure we have a test that covers that via a follow up
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
Signed-off-by: jiaxiao zhou <[email protected]>
|
@jsturtevant It turns out that wasmedge benchmarking wasn't working - it times out after 10 seconds. I need more time to investigate the WasmEdge case, so for this PR, I removed it. |
jprendes
reviewed
Jun 14, 2024
benches/containerd-shim-benchmarks/benches/webassembly-benchmarks.rs
Outdated
Show resolved
Hide resolved
benches/containerd-shim-benchmarks/benches/webassembly-benchmarks.rs
Outdated
Show resolved
Hide resolved
Signed-off-by: jiaxiao zhou <[email protected]>
|
Going to merge this in. Will work on the follow ups. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit reverts back a change made by commit SHA 6882dd5 and fixed all the build errors for the benchmark.
cargo benchto GitHub ActionsCloses #611