Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept / draft for #3027
Average, very un-scientific measurements for
nerdctl images
:On 500 identical images at 270MB:
On 500 identical images (buysbox, one layer, 4.174MB):
For about 250 containers (
nerdctl ps -as
) started from the same image (the big one above), results are in the same ballpark: about 50% gain with cache.This PR also consolidates code and reduce duplication I did introduce...
Let me know if this is something we should consider.
If yes, we can iterate on design / code location and possibly simplify the signature of
imgutil.SnapshotServiceWithCache
for eg.