Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand filters for walking images #2106

Closed
wants to merge 1 commit into from

Conversation

ginglis13
Copy link
Contributor

fixes #2061

adds filters for walking images in the containerd store to cover the case of @sha256:

fixes containerd#2061

adds filters for walking images in the containerd store
to cover the case of <ref>@sha256:<digest>

Signed-off-by: Gavin Inglis <[email protected]>
@AkihiroSuda
Copy link
Member

fixes #2061

The problem is that nerdctl pull hello-world; nerdctl pull hello-world@sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb creates two images in the image store. So I don't think that this PR solves this issue.

@ginglis13
Copy link
Contributor Author

The problem is that nerdctl pull hello-world; nerdctl pull hello-world@sha256:6e8b6f026e0b9c419ea0fd02d3905dd0952ad1feea67543f525c73a0a790fefb creates two images in the image store. So I don't think that this PR solves this issue.

ah I misunderstood the root issue. let me convert to draft and take a closer look

@ginglis13 ginglis13 marked this pull request as draft March 16, 2023 17:04
@ginglis13 ginglis13 closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hello-world and hello-world@sha256:... are treated as different images
2 participants