Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Replace lurker package #1007

Conversation

pixelbrackets
Copy link
Contributor

Overview

This pull request:

  • Fixes a bug
  • Adds a feature
  • Breaks backwards compatibility
  • Has tests that cover changes
  • Adds or fixes documentation

Summary

The watch task requires the package »henrikbjorn/lurker«.
The dependencies of this package dont allow using Symfony 4.
Last release of this package was 2016-03-16. So its abdandoned.

Use the drop-in replacement package totten/lurkerlite instead.
Installing this packsge will remove »henrikbjorn/lurker« automatically.

Since the package is a designated drop-in replacement all existing
methods in robo may stay the same.

Description

Closes #459 #956 #973

The watch task requires the package »henrikbjorn/lurker«.
The dependencies of this package dont allow using Symfony 4.
Last release of this package was 2016-03-16. So its abdandoned.

Use the drop-in replacement package totten/lurkerlite instead.
Installing this packsge will remove »henrikbjorn/lurker« automatically.

Since the package is a designated drop-in replacement all existing
methods in robo may stay the same.

Closes consolidation#459 consolidation#956 consolidation#973
@codecov
Copy link

codecov bot commented Dec 18, 2020

Codecov Report

Merging #1007 (7a2d262) into 3.x (a9d110b) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.x    #1007   +/-   ##
=========================================
  Coverage     46.19%   46.19%           
  Complexity     2032     2032           
=========================================
  Files           152      152           
  Lines          5213     5213           
=========================================
  Hits           2408     2408           
  Misses         2805     2805           
Impacted Files Coverage Δ Complexity Δ
src/Task/Base/Watch.php 0.00% <0.00%> (ø) 7.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9d110b...7a2d262. Read the comment docs.

@greg-1-anderson greg-1-anderson merged commit 8e5d1f7 into consolidation:3.x Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing: composer require henrikbjorn/lurker
2 participants