-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Render placeholders in menu_name
#175
Conversation
cc @marcoesters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
However, I am wondering if the rendering should be happening inside _load
inside api.py
All the item rendering happens in the MenuItem instance. Directory creation also happens in the Menu class. I don't see how this would be beneficial 🤔 I'll merge for now and if necessary we can open a new PR. Thanks! |
Description
I had forgotten to render placeholders found in the
menu_name
key. This fixes that behavior so folks can things like do"menu_name": "{{ DISTRIBUTION_NAME }} shortcuts"
to customize the Start Menu directory.Checklist - did you ...
news
directory (using the template) for the next release's release notes?