Simplify cron for checking to see if its the conda-forge wednesday #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaimergp
reviewed
Jun 29, 2023
| if wednesday.date() == today.date(): | ||
| print("Match! Job should run.") | ||
| import datetime, sys | ||
| year, week, weekday = dt.isocalendar() |
There was a problem hiding this comment.
Suggested change
| year, week, weekday = dt.isocalendar() | |
| year, week, weekday = datetime.today().isocalendar() |
You mean this, right?
jaimergp
reviewed
Jun 29, 2023
Comment on lines
+56
to
+63
| if week % 2 == 0: | ||
| # conda forge meeting on even weeks | ||
| print("conda-forge meeting match! Job should run.") | ||
| with open(os.environ['GITHUB_ENV'], 'a') as f: | ||
| print("should_run=yes", f) | ||
| elif wednesday > today: | ||
| print("Didn't match. Aborting.") | ||
| break | ||
| else: | ||
| # conda community meeting on odd weeks | ||
| print('conda community meeting!') |
There was a problem hiding this comment.
Nice, I checked and we do:
- conda-forge on even weeks
- conda-incubator on odd weeks
So for this repo we need to reverse the logic, but for conda-forge we need to migrate it. The problem is that we have been creating the meeting notes with some days in advance now (sometimes as soon as the meeting was over), so we need to do the check not for "today" but for the next even Wednesday.
So all in all I feel that this daily logic is not serving the community needs anymore. We probably need something like:
# runs every Thursday
if week_is_even:
date = next_even_wednesday()
export_date_to_env()
else:
exit 0 # do not run and wait for next week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @jaimergp I think this is a bit simpler and should work? could use a careful review though