Conversation
conda-bot
added
the
cla-signed
|
@ryanskeith Can you try and fix the CI? Happy to move forward with this! |
…o do the same thing.
|
I took some time to set up testing on Linux yesterday after the many attempts of CI failures. The tests do pass on Linux. I am going to revert back most the test changes and then take a very, very close look at how the CI is affecting the testing on Linux. It still seems weird why they seem to be failing in the first place. |
testing/setup_envs.sh
Outdated
| # Remove this package from the cache for testing | ||
| rm -rf $croot/pkgs/conda_pack_test_lib2*py310* | ||
| # Remove this package from the cache for testing -> test_missing_package_cache | ||
| rm -rf "$CONDA_PKGS_DIRS/conda_pack_test_lib2"*py310* |
There was a problem hiding this comment.
$CONDA_PKGS_DIRS can be a list instead of a single directory
…necssary channel.
| ] | ||
| requires-python = ">=3.9" | ||
| dependencies = [ | ||
| "setuptools", |
There was a problem hiding this comment.
Intriguing that this is only needed to copy the trampoline executable on Windows.
.pre-commit-config.yaml
Outdated
| rev: 7.3.0 | ||
| hooks: | ||
| - id: flake8 | ||
| args: ["--max-line-length=100"] |
There was a problem hiding this comment.
Isn't this enforced by the TOML configuration in pyproject? 🤔
There was a problem hiding this comment.
Honestly, I am also confused by this. This was one of the first things I added to make pre-commit run correctly. This was log was before I added this line. https://results.pre-commit.ci/run/github/107311555/1761328504.pnrw8J_eSFuZP5DXavhm-w
There was a problem hiding this comment.
Looks like flake8 does not support pyproject.toml as a configuration source. No mention in https://flake8.pycqa.org/en/latest/user/configuration.html#configuration-locations, and the existence of https://pypi.org/project/Flake8-pyproject/ is very telling. Might need to move it to .flake8 or install that compatibility adapter.
There was a problem hiding this comment.
We could also remove the flake8 runs as well and move to another linter.
@jaimergp what do you need to accept this PR?
There was a problem hiding this comment.
I have permissions inherited by the constructor team but I haven't really committed to this project, so I'd defer the approval to @xhochy.
There was a problem hiding this comment.
I'm back in the office next week and will review then 😉
There was a problem hiding this comment.
@xhochy friendly reminder to take a look when you have time this week.
There was a problem hiding this comment.
I'll put this in a .flake8 and we could move to a separate linter in a follow-up PR.
Updating release date.
- Extract first directory from CONDA_PKGS_DIRS which may contain multiple paths - Add error handling to rm command to prevent failures when files don't exist - Supports both Unix (:) and Windows (;) path separators
6 participants
Description
We will still need a maintainer to tag and release version 0.9.0.