handle dynamic tags unknown to lief

[cbouss]

Description

Lief dynamic entry tags are defined here:
https://github.com/lief-project/LIEF/blob/main/include/LIEF/ELF/DynamicEntry.hpp#L47

We are seeing linux aarch64 binaries with tag TLSDESC_PLT, which is not defined in lief. lief stores that tag as a its hex value instead as an instance of lief.ELF.DynamicEntry.TAG.

conda build trips on this while looking for tag SONAME, with a ValueError: 1879047926 is not a valid TAG., as described in this issue: #5665

This is true for both lief 0.16.4 and 0.16.6.

Used workaround have been so far to:

• pin lief to version 0.12.3, which does not have TLSDESC_PLT defined, but does not throw a value error. Pin lief to avoid "ValueError: 1879047926 is not a valid TAG" bug in newer versions anaconda/docker-images#682
• use overlinking_ignore_patterns. Pkg 8275 oracle instant client latest AnacondaRecipes/oracle-instant-client-feedstock#1

This change filters dynamic_entries to only valid instances of ELF_DYNAMIC_TAGS.

Checklist - did you ...

• Add a file to the news directory (using the template) for the next release's release notes?
• Add / update necessary tests?
• Add / update outdated documentation?

[ryanskeith]

Thank you so much. This looks good to me.

[codspeed-hq]

CodSpeed Performance Report

Merging #5778 will not alter performance

_{Comparing cbouss:handle-unknown-dynamic-tags (29ba651) with main (bf20637)}

Summary

✅ 5 untouched

[kenodegard]

While some of the test failures are unrelated, e.g.:

• Ignore CondaSolver deprecation warnings for a bit #5779
• Test suite failure for libc++ #5785

Others are possibly related?

[ryanskeith]

These changes look great to me. Thank you @cbouss and @kenodegard

[ryanskeith]

@cbouss let's work together to figure out why the tests are failing.

I reviewed before that tests ran. Somehow they required manual approval to run so it looked liked all was green.

[jaimergp]

I rebased so we can get a functional CI again, but looks like there are some failing tests concerning this PR, @cbouss:

FAILED tests/test_post.py::test_file_hash - conda_build.exceptions.OverLinkingError: <exception str() failed>
FAILED tests/test_post.py::test_rpath_symlink - conda_build.exceptions.CondaBuildUserError: TESTS FAILED: rpath_symlink-1.0.0-h52ea4df_0.conda

[tkelman]

Don't consider this question blocking at all for this workaround, but would there be any reason upstream lief wouldn't want to add an entry for TLSDESC_PLT to that enum?

[jaimergp]

Don't consider this question blocking at all for this workaround, but would there be any reason upstream lief wouldn't want to add an entry for TLSDESC_PLT to that enum?

@tkelman, I guess that could work, but first they'd need an issue report. I tried opening one but couldn't come up with a reproducer. Here are some references that could help with the report:

• https://www.fsfla.org/~lxoliva/writeups/TLS/RFC-TLSDESC-x86.txt
• https://www.fsfla.org/~lxoliva/writeups/TLS/RFC-TLSDESC-ARM.txt