Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be explicit about macOS runner choices in GHA workflows #5309

Merged
merged 7 commits into from
Apr 25, 2024
Merged

Be explicit about macOS runner choices in GHA workflows #5309

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
963a158
Be explicit about macOS runner choices in GHA workflows
jaimergp Apr 23, 2024
6457822
install latest miniconda
jaimergp Apr 23, 2024
7e62640
Bump SDK
jaimergp Apr 23, 2024
137306e
correct macos version
jaimergp Apr 23, 2024
65d833d
pre-commit
jaimergp Apr 23, 2024
d63e5dc
revert and document choice
jaimergp Apr 23, 2024
53b687c
pre-commit
jaimergp Apr 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,10 @@ jobs:
needs: changes
if: github.event_name == 'schedule' || needs.changes.outputs.code == 'true'

# Old macOS needed for old SDK (see xcode step below)
# This is needed for some MACOSX_DEPLOYMENT_TARGET tests
# We could also install SDKs from a external provider in the future
# if we want to update this runner to a non-deprecated version
runs-on: macos-11
defaults:
run:
Expand Down Expand Up @@ -489,9 +493,9 @@ jobs:
include:
- runner: ubuntu-latest
subdir: linux-64
- runner: macos-latest
- runner: macos-13
subdir: osx-64
- runner: macos-14
- runner: macos-14 # FUTURE: Use -latest
subdir: osx-arm64
- runner: windows-latest
subdir: win-64
Expand Down
Loading