Skip to content

Commit

Permalink
Be explicit about macOS runner choices in GHA workflows (#5309)
Browse files Browse the repository at this point in the history
* Be explicit about macOS runner choices in GHA workflows

* install latest miniconda

* Bump SDK

* correct macos version

* pre-commit

* revert and document choice

* pre-commit
  • Loading branch information
jaimergp authored Apr 25, 2024
1 parent 7573412 commit 3f9346f
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -337,6 +337,10 @@ jobs:
needs: changes
if: github.event_name == 'schedule' || needs.changes.outputs.code == 'true'

# Old macOS needed for old SDK (see xcode step below)
# This is needed for some MACOSX_DEPLOYMENT_TARGET tests
# We could also install SDKs from a external provider in the future
# if we want to update this runner to a non-deprecated version
runs-on: macos-11
defaults:
run:
Expand Down Expand Up @@ -489,9 +493,9 @@ jobs:
include:
- runner: ubuntu-latest
subdir: linux-64
- runner: macos-latest
- runner: macos-13
subdir: osx-64
- runner: macos-14
- runner: macos-14 # FUTURE: Use -latest
subdir: osx-arm64
- runner: windows-latest
subdir: win-64
Expand Down

0 comments on commit 3f9346f

Please sign in to comment.