Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read-file action #203

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Add read-file action #203

wants to merge 42 commits into from

Conversation

kenodegard
Copy link
Contributor

@kenodegard kenodegard commented Aug 16, 2024

Description

Depends on #243

Adding a read-file action that will support reading a local or remote file and supports both JSON and Yaml but will also allow leaving the output as a plain string.

This action replaces read-yaml.

@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Aug 16, 2024
Copy link
Member

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

jezdez
jezdez previously approved these changes Aug 27, 2024
@kenodegard kenodegard marked this pull request as ready for review December 17, 2024 19:42
@kenodegard kenodegard requested a review from a team as a code owner December 17, 2024 19:42
pyproject.toml Outdated
@@ -21,7 +25,6 @@ addopts = [
"--tb=native",
"-vv",
]
testpaths = ["**/"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason this doesn't find test_read_file.py but the pytest's default recursive search finds the tests

@kenodegard kenodegard mentioned this pull request Jan 9, 2025
read-file/read_file.py Outdated Show resolved Hide resolved
@kenodegard kenodegard marked this pull request as ready for review January 10, 2025 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

3 participants