Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't build conda store cli #1019
base: main
Are you sure you want to change the base?
Don't build conda store cli #1019
Changes from all commits
7b78ee3
da8eb29
0dbc04a
4276589
5b6ccfd
89a2bb5
821a6e3
d6a2f63
261bbcc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a lot of places where we use
conda-store-server
, which might change as we consolidate the packages. I suggest setting a job-level env variable for this and reusing the variable instead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the amount of effort it will take to introduce a job-level variable will be pretty similar to the amount of effort it will take to explicitly rename things. Since (1) we should only be renaming
conda-store-server
->conda-store
once, and (2) it is easier to read + debug yaml files (and ci) that use explicit names opposed to variables, I would prefer not to introduce this variable.But open to doing it if I'm missing an important upside that it will provide. I think it would be appropriate to do that work in a follow up PR
This file was deleted.