Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add harmony-py Python package #25149

Merged
merged 4 commits into from
Feb 12, 2024
Merged

Conversation

jhkennedy
Copy link
Contributor

@jhkennedy jhkennedy commented Jan 27, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/harmony-py) and found some lint.

Here's what I've got...

For recipes/harmony-py:

  • The following maintainers have not yet confirmed that they are willing to be listed here: ashiklom, owenlittlejohns, betolink. Please ask them to comment on this PR if they are.

@jhkennedy
Copy link
Contributor Author

@ashiklom, @betolink, and @owenlittlejohns can y'all comment you're willing to be a maintainer?

@jhkennedy
Copy link
Contributor Author

Alright, failure is because the source tarball does not contain the requirements files that are parsed in the setup.py:
https://github.com/nasa/harmony-py/blob/main/setup.py#L17-L23

That's a next week kinda problem.

@owenlittlejohns
Copy link

For sure, happy to help here, @jhkennedy

@betolink
Copy link
Member

Sure thing @jhkennedy!

@ashiklom
Copy link

ashiklom commented Jan 29, 2024 via email

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/harmony-py) and found it was in an excellent condition.

recipes/harmony-py/76.diff Outdated Show resolved Hide resolved
@jhkennedy
Copy link
Contributor Author

jhkennedy commented Feb 12, 2024

Okay, this recipe should be ready for review! (sorry it took so long to circle back; got waylaid by sick kids)

Upstream, I opened:

@jhkennedy
Copy link
Contributor Author

@conda-forge/help-python, ready for review!

@ocefpaf ocefpaf merged commit 9387362 into conda-forge:main Feb 12, 2024
5 checks passed
@jhkennedy jhkennedy deleted the add-harmony-py branch February 13, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants