-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Tigervnc #21393
WIP: Tigervnc #21393
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Still todo:
|
This fails when trying to build Xvnc:
I can't see a way forward from here. |
Need to bump up the version at https://github.com/conda-forge/xorg-randrproto-feedstock/blob/0af6e0d5af5e9dc3bf71bb59d5e782479dbc0032/recipe/meta.yaml#L4 from 1.5.0 to 1.6.0?
Not sure about these, don't see them on conda-forge yet. |
Co-authored-by: Wei Ji <[email protected]>
It looks like randrproto isn't pulling from a standard source repo, which is probably why it's not been automatically updated: |
Was gonna manually bump randrproto from 1.5.0 to 1.6.0, but I couldn't find it in https://www.x.org/releases/individual/proto or https://gitlab.freedesktop.org/xorg/proto/randrproto, the latest tagged version seems to be 1.5.0?!! No idea where tigervnc is pulling this from 😅 Edit: Ah, I see at https://gitlab.freedesktop.org/xorg/proto/randrproto/-/commit/72f0d2a21ba47b25fd773be3ace135aed5c6678f that |
Co-authored-by: Wei Ji <[email protected]>
2022.2 results in ``` In file included from /miniforge3/envs/tiger/include/X11/XKBlib.h:31, from /tigervnc/unix/x0vncserver/XDesktop.h:28, from /tigervnc/unix/x0vncserver/x0vncserver.cxx:43: /miniforge3/envs/tiger/include/X11/extensions/XKBstr.h:405:28: error: expected ';' at end of member declaration 405 | char name[XkbKeyNameLength] _X_NONSTRING; ```
@conda-forge-admin, please restart ci |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
- xorg-util-macros | ||
# For building Xvnc (needs to be here and in host) | ||
- libxkbfile | ||
- xorg-xorgproto <2022.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove pinning to bring in xorg-xorgproto 2022.2? Update was made in conda-forge/xorg-xorgproto-feedstock#3
- xorg-xorgproto <2022.1 | |
- xorg-xorgproto |
- xorg-libxi | ||
# For building Xvnc | ||
- libxkbfile | ||
- xorg-xorgproto <2022.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- xorg-xorgproto <2022.1 | |
- xorg-xorgproto |
@@ -0,0 +1,92 @@ | |||
{% set name = "tigervnc" %} | |||
{% set version = "1.12.0" %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try building tigervnc=1.13.1?
{% set version = "1.12.0" %} | |
{% set version = "1.13.1" %} |
{% set xorg_x11_server_version = "1.20.14" %} | ||
|
||
package: | ||
name: {{ name|lower }} | ||
version: {{ version }} | ||
|
||
source: | ||
- url: https://github.com/TigerVNC/tigervnc/archive/v{{ version }}.tar.gz | ||
sha256: 9ff3f3948f2a4e8cc06ee598ee4b1096beb62094c13e0b1462bff78587bed789 | ||
patches: | ||
# Disables vncsession (requires PAM and runs as root) | ||
# Disable PAM password check (always return failure) | ||
- ignore-pam.patch | ||
# https://github.com/TigerVNC/tigervnc/blob/v1.12.0/BUILDING.txt#L100-L146 | ||
- url: https://github.com/freedesktop/xorg-xserver/archive/xorg-server-{{ xorg_x11_server_version }}.tar.gz | ||
sha256: 68105526da70d04f7111339044cdd5b2a762717178cd345aba6cb2d1b399c71b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like xorg-xserver has moved from GitHub to GitLab at https://gitlab.freedesktop.org/xorg/xserver? The GitHub link doesn't work anymore
Hi friend! We really, really, really appreciate that you have taken the time to make a PR on In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on Cheers and thank you for contributing to this community effort! |
Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is Cheers and have a great day! |
This is a prerequisite for #21369
This is a modified version of #17740
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).