Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Tigervnc #21393

Closed
wants to merge 14 commits into from
Closed

WIP: Tigervnc #21393

wants to merge 14 commits into from

Conversation

manics
Copy link
Member

@manics manics commented Nov 30, 2022

This is a prerequisite for #21369
This is a modified version of #17740

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tigervnc) and found it was in an excellent condition.

@manics
Copy link
Member Author

manics commented Nov 30, 2022

Still todo:

@manics manics mentioned this pull request Nov 30, 2022
10 tasks
@manics
Copy link
Member Author

manics commented Dec 2, 2022

This fails when trying to build Xvnc:

checking for fixesproto >= 5.0 damageproto >= 1.1 xcmiscproto >= 1.2.0 xtrans >= 1.3.5 bigreqsproto >= 1.1.0 xproto >= 7.0.31 randrproto >= 1.6.0 renderproto >= 0.11 xextproto >= 7.2.99.901 inputproto >= 2.3 kbproto >= 1.0.3 fontsproto >= 2.1.3 pixman-1 >= 0.27.2 videoproto compositeproto >= 0.4 recordproto >= 1.13.99.1 scrnsaverproto >= 1.1 resourceproto >= 1.2.0 presentproto >= 1.1 xkbfile  pixman-1 >= 0.27.2 xfont2 >= 2.0.0 xau xdmcp... no
configure: error: Package requirements (fixesproto >= 5.0 damageproto >= 1.1 xcmiscproto >= 1.2.0 xtrans >= 1.3.5 bigreqsproto >= 1.1.0 xproto >= 7.0.31 randrproto >= 1.6.0 renderproto >= 0.11 xextproto >= 7.2.99.901 inputproto >= 2.3 kbproto >= 1.0.3 fontsproto >= 2.1.3 pixman-1 >= 0.27.2 videoproto compositeproto >= 0.4 recordproto >= 1.13.99.1 scrnsaverproto >= 1.1 resourceproto >= 1.2.0 presentproto >= 1.1 xkbfile  pixman-1 >= 0.27.2 xfont2 >= 2.0.0 xau xdmcp) were not met:

Requested 'randrproto >= 1.6.0' but version of RandrProto is 1.5.0
No package 'xkbfile' found
No package 'xfont2' found

I can't see a way forward from here.

@weiji14
Copy link
Member

weiji14 commented Dec 2, 2022

Requested 'randrproto >= 1.6.0' but version of RandrProto is 1.5.0

Need to bump up the version at https://github.com/conda-forge/xorg-randrproto-feedstock/blob/0af6e0d5af5e9dc3bf71bb59d5e782479dbc0032/recipe/meta.yaml#L4 from 1.5.0 to 1.6.0?

No package 'xkbfile' found
No package 'xfont2' found

Not sure about these, don't see them on conda-forge yet.

@manics
Copy link
Member Author

manics commented Dec 2, 2022

It looks like randrproto isn't pulling from a standard source repo, which is probably why it's not been automatically updated:
https://github.com/conda-forge/xorg-randrproto-feedstock/blob/0af6e0d5af5e9dc3bf71bb59d5e782479dbc0032/recipe/meta.yaml#L4-L14

@weiji14
Copy link
Member

weiji14 commented Dec 2, 2022

It looks like randrproto isn't pulling from a standard source repo, which is probably why it's not been automatically updated: https://github.com/conda-forge/xorg-randrproto-feedstock/blob/0af6e0d5af5e9dc3bf71bb59d5e782479dbc0032/recipe/meta.yaml#L4-L14

Was gonna manually bump randrproto from 1.5.0 to 1.6.0, but I couldn't find it in https://www.x.org/releases/individual/proto or https://gitlab.freedesktop.org/xorg/proto/randrproto, the latest tagged version seems to be 1.5.0?!! No idea where tigervnc is pulling this from 😅

Edit: Ah, I see at https://gitlab.freedesktop.org/xorg/proto/randrproto/-/commit/72f0d2a21ba47b25fd773be3ace135aed5c6678f that randrproto has been deprecated in favour of xorgproto, see https://github.com/freedesktop/xorg-xorgproto. The feedstock is at https://github.com/conda-forge/xorg-xorgproto-feedstock

recipes/tigervnc/meta.yaml Outdated Show resolved Hide resolved
recipes/tigervnc/meta.yaml Outdated Show resolved Hide resolved
manics and others added 2 commits December 3, 2022 17:52
2022.2 results in
```
In file included from /miniforge3/envs/tiger/include/X11/XKBlib.h:31,
                 from /tigervnc/unix/x0vncserver/XDesktop.h:28,
                 from /tigervnc/unix/x0vncserver/x0vncserver.cxx:43:
/miniforge3/envs/tiger/include/X11/extensions/XKBstr.h:405:28: error: expected ';' at end of member declaration
  405 |  char name[XkbKeyNameLength] _X_NONSTRING;
```
@weiji14
Copy link
Member

weiji14 commented Apr 26, 2023

@conda-forge-admin, please restart ci

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/tigervnc) and found it was in an excellent condition.

- xorg-util-macros
# For building Xvnc (needs to be here and in host)
- libxkbfile
- xorg-xorgproto <2022.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove pinning to bring in xorg-xorgproto 2022.2? Update was made in conda-forge/xorg-xorgproto-feedstock#3

Suggested change
- xorg-xorgproto <2022.1
- xorg-xorgproto

- xorg-libxi
# For building Xvnc
- libxkbfile
- xorg-xorgproto <2022.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- xorg-xorgproto <2022.1
- xorg-xorgproto

@@ -0,0 +1,92 @@
{% set name = "tigervnc" %}
{% set version = "1.12.0" %}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try building tigervnc=1.13.1?

Suggested change
{% set version = "1.12.0" %}
{% set version = "1.13.1" %}

Comment on lines +3 to +18
{% set xorg_x11_server_version = "1.20.14" %}

package:
name: {{ name|lower }}
version: {{ version }}

source:
- url: https://github.com/TigerVNC/tigervnc/archive/v{{ version }}.tar.gz
sha256: 9ff3f3948f2a4e8cc06ee598ee4b1096beb62094c13e0b1462bff78587bed789
patches:
# Disables vncsession (requires PAM and runs as root)
# Disable PAM password check (always return failure)
- ignore-pam.patch
# https://github.com/TigerVNC/tigervnc/blob/v1.12.0/BUILDING.txt#L100-L146
- url: https://github.com/freedesktop/xorg-xserver/archive/xorg-server-{{ xorg_x11_server_version }}.tar.gz
sha256: 68105526da70d04f7111339044cdd5b2a762717178cd345aba6cb2d1b399c71b
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like xorg-xserver has moved from GitHub to GitLab at https://gitlab.freedesktop.org/xorg/xserver? The GitHub link doesn't work anymore

@stale
Copy link

stale bot commented Sep 28, 2023

Hi friend!

We really, really, really appreciate that you have taken the time to make a PR on conda-forge/staged-recipes! conda-forge only exists because people like you donate their time to build and maintain conda recipes for use by the community.

In an effort to maintain this repository and increase the signal-to-noise for open PRs, the maintainers of staged-recipes close excessively old PRs after six months. This PR will remain open for another month, and then will be closed.

If you'd like to keep it open, please comment/push and we will be happy to oblige! Note that very old PRs will likely need to be rebased on main so that they can be rebuilt with the most recent CI scripts. If you have any trouble, or we missed reviewing this PR in the first place (sorry!), feel free to ping the team using a special command in a comment on the PR to get the attention of the staged-recipes team.

Cheers and thank you for contributing to this community effort!

@stale stale bot added the stale will be closed in 30 days label Sep 28, 2023
Copy link

stale bot commented Jan 1, 2024

Hi again! About a month ago, we commented on this PR saying it would be closed in another month if it was still inactive. It has been a month and so now it is being closed. Thank you so much for making it in the first place and contributing to the community project that is conda-forge. If you'd like to reopen this PR, please feel free to do so at any time!

Cheers and have a great day!

@stale stale bot closed this Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale will be closed in 30 days
Development

Successfully merging this pull request may close these issues.

4 participants