Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build a variant without features to use latest sysroot outside conda-build #75

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 7, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@isuruf
Copy link
Member Author

isuruf commented Oct 7, 2024

@conda-forge-admin rerender

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • License exception is not an SPDX exception.

Documentation on acceptable licenses can be found here.

@h-vetinari h-vetinari mentioned this pull request Oct 9, 2024
5 tasks
@isuruf isuruf marked this pull request as ready for review October 9, 2024 13:11
Copy link
Member

@beckermr beckermr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am 99% sure @mbargull said this kind of package would break bioconda builds. Maybe he can comment here?

cc @conda-forge/core for viz

@isuruf
Copy link
Member Author

isuruf commented Oct 9, 2024

Not really. I checked and they use a cos7 based docker image, so they would still get sysroot_linux-64=2.17 by default

@beckermr
Copy link
Member

beckermr commented Oct 9, 2024

How does that work? I guess the runtime constraint on glibc?

@isuruf
Copy link
Member Author

isuruf commented Oct 9, 2024

I guess the runtime constraint on glibc?

Yes

@beckermr
Copy link
Member

beckermr commented Oct 9, 2024

The other way we had wanted to work on this was to enable a "system" sysroot where our compilers would use whatever sysroot is available on the system itself.

@jakirkham
Copy link
Member

Thanks Isuru! 🙏

FWIW think this would be a great improvement for users leveraging our toolchain in development environments

Matt makes a good point about having an option to use the "system" sysroot. IIUC we could make that change as well. IOW this change shouldn't limit it us in enabling that option in the future

As to Bioconda, see Isuru suggested moving to {{ stdlib("c") }} in issue ( bioconda/bioconda-recipes#51185 ). Looks like they had some hangups with linting. Though don't have any more details as the log they shared expired. Perhaps once someone includes fresh details there, we can learn how much of a lift it would be for them to add use {{ stdlib("c") }}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants