-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build a variant without features to use latest sysroot outside conda-build #75
base: main
Are you sure you want to change the base?
Conversation
@conda-forge-admin rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( For recipe/meta.yaml:
Documentation on acceptable licenses can be found here. |
…nda-forge-pinning 2024.10.07.11.58.12
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am 99% sure @mbargull said this kind of package would break bioconda builds. Maybe he can comment here?
cc @conda-forge/core for viz
Not really. I checked and they use a cos7 based docker image, so they would still get sysroot_linux-64=2.17 by default |
How does that work? I guess the runtime constraint on glibc? |
Yes |
The other way we had wanted to work on this was to enable a "system" sysroot where our compilers would use whatever sysroot is available on the system itself. |
Thanks Isuru! 🙏 FWIW think this would be a great improvement for users leveraging our toolchain in development environments Matt makes a good point about having an option to use the "system" sysroot. IIUC we could make that change as well. IOW this change shouldn't limit it us in enabling that option in the future As to Bioconda, see Isuru suggested moving to |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)