Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dandi v0.46.3 #84

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Conversation

regro-cf-autotick-bot
Copy link
Contributor

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

  • Dependencies have been updated if changed: see upstream
  • Tests have passed
  • Updated license if changed and license_file is packaged

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with @conda-forge-admin,please add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase @conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #83

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

  • finesse
  • hdmf
  • numpy

Packages found in the meta.yaml but not found by source code inspection:

  • pycryptodomex

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3085232590, please use this URL for debugging.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@jwodder
Copy link
Member

jwodder commented Sep 19, 2022

@yarikoptic bidsschematools is still not on conda-forge, so we can't release this.

@yarikoptic
Copy link
Contributor

doh, right. Could you please prepare feedstock for it @jwodder?

@jwodder
Copy link
Member

jwodder commented Sep 20, 2022

@yarikoptic Whom should I list as recipe maintainers?

@yarikoptic
Copy link
Contributor

both of us and @TheChymera (you would not mind @TheChymera, right? it is easy) for now

@TheChymera
Copy link

TheChymera commented Sep 20, 2022

@yarikoptic I'm not sure what this does actually, but I can try to find out. In case this has to do with packaging releases, I try to do that on a regular basis and report bugs on the issue tracker anyway — but that uses a different build system.

@yarikoptic
Copy link
Contributor

I will give you a brief run through it whenever we meet in person. It is very easy and automations make it really trivial. Just want to have you on board for an occasional quick fix up etc.

@jwodder
Copy link
Member

jwodder commented Sep 23, 2022

@yarikoptic The tests are now failing because the latest version of nwbinspector on conda-forge is 0.4.12, yet the latest version on PyPI is 0.4.13, and so nwbinspector errors out with a message telling you to upgrade.

@yarikoptic
Copy link
Contributor

@yarikoptic The tests are now failing because the latest version of nwbinspector on conda-forge is 0.4.12, yet the latest version on PyPI is 0.4.13, and so nwbinspector errors out with a message telling you to upgrade.

@CodyCBakerPhD I thought we have discussed making nwbinspector more "understanding" to be ran of some older version, unless it is known to be so extremely buggy that it must not be used. I can continue that discussion that demanding running most recent version would forbid inclusion of nwbinspector to any stable linux distribution. I think it would be left for user and downstream projects to react to warning to upgrade or demand some specific version(s) through versioning dependencies. Will 0.4.13 be more "forgiving" or should we wait for some other version? ;-)

@CodyCBakerPhD
Copy link

Will 0.4.13 be more "forgiving" or should we wait for some other version?

The bug fix has been available for a while: NeurodataWithoutBorders/nwbinspector#264

But held up waiting on approval

@yarikoptic
Copy link
Contributor

Will 0.4.13 be more "forgiving" or should we wait for some other version?

The bug fix has been available for a while: NeurodataWithoutBorders/nwbinspector#264

But held up waiting on approval

I do not see how that PR relates directly to the check. Could you please explain?

@CodyCBakerPhD
Copy link

I do not see how that PR relates directly to the check. Could you please explain?

The bug that is causing the problem on conda-forge/nwbinspector-feedstock#8 (well, aside from the fact that the latest PyNWB isn't available, which would resolve that for the testing suite) is actually a very minor one.

There's one particular neurodata type (the Intracellular electrode) that has different attributes available to it depending on both which version of PyNWB was used to write the file and what version of PyNWB is being used to read the file. The check function was originally written in a way that assumed a particular attribute (the cell_id) was always available, which is only true for the latest PyNWB version (the one on PyPI). The debug is to skip the check and adjust the testing suite behavior on older API versions.

@CodyCBakerPhD
Copy link

Just note that most people running the NWB Inspector through PyPI releases (or the conda-forge release, if we forced it through) would likely not encounter any problem with respect to this issue, and even if they did it would get captured in the final Inspector report. So it's not a huge worry about usability, it's more of just a testing suite adjustment thing.

@CodyCBakerPhD
Copy link

Fix is merged, included in new release of https://pypi.org/project/nwbinspector/0.4.14/ available as soon as the conda-forge catches it

@CodyCBakerPhD
Copy link

NWBInspector v0.4.14 is now on conda-forge without issues: conda-forge/nwbinspector-feedstock#9, sorry for holding up your release cycle.

@jwodder jwodder merged commit 8656444 into conda-forge:main Sep 26, 2022
@regro-cf-autotick-bot regro-cf-autotick-bot deleted the 0.46.3_hde9848 branch September 26, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants