Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate libcxx version that matches compiler #134

Merged
merged 3 commits into from
Aug 7, 2024
Merged

Reinstate libcxx version that matches compiler #134

merged 3 commits into from
Aug 7, 2024

Conversation

h-vetinari
Copy link
Member

We've finally caught back up after conda-forge/libcxx-feedstock#155 got merged. 🙃

C.f. list in #131 (resp. #113 before #128)

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@h-vetinari
Copy link
Member Author

Waiting for conda-forge/libcxx-feedstock#160

@h-vetinari h-vetinari mentioned this pull request Jul 27, 2024
Merged
15 tasks
@h-vetinari h-vetinari marked this pull request as draft July 28, 2024 09:12
@h-vetinari
Copy link
Member Author

Draft at least until we fix conda-forge/libcxx-feedstock#162

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

@h-vetinari h-vetinari marked this pull request as ready for review July 31, 2024 00:22
@h-vetinari
Copy link
Member Author

@conda-forge/clang-compiler-activation, with this PR we're finally ready to go back to the way things worked before the macOS 10.13 bump caused things to diverge for a while. PTAL :)

@h-vetinari
Copy link
Member Author

Gentle ping @conda-forge/clang-compiler-activation :)

@h-vetinari h-vetinari mentioned this pull request Aug 5, 2024
Merged
15 tasks
isuruf
isuruf approved these changes Aug 7, 2024
View reviewed changes
Copy link
Member

@isuruf isuruf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep libcxx_major jinja variable and set it to version? Reduces churn now and in the future too.

@h-vetinari h-vetinari added the automerge Merge the PR when CI passes label Aug 7, 2024
@github-actions github-actions bot merged commit 76c5b95 into conda-forge:main Aug 7, 2024
26 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 7, 2024

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

  • linter: passed
  • azure: passed

Thus the PR was passing and merged! Have a great day!

@h-vetinari h-vetinari deleted the libcxx branch August 8, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isuruf isuruf isuruf approved these changes

@katietz katietz Awaiting requested review from katietz katietz is a code owner

@mingwandroid mingwandroid Awaiting requested review from mingwandroid mingwandroid is a code owner

Assignees
No one assigned
Labels
automerge Merge the PR when CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h-vetinari @isuruf