Add support for securely passing ssh identity to docker build #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eric Bellotti <[email protected]>
ericb-summit
force-pushed
the
summit/feature/docker_ssh
branch
from
ab8f021 to
e76718f
Compare
|
Hi could you add a out test in tests/out_test.go if possible? |
|
This fix has been re-implemented here: #364 |
This was referenced Apr 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Dockerfile builds require ssh authentication to perform some operations. Most notably pulling dependencies from private repos. To avoid leaking the ssh credentials in the build layers, docker buildkit supports the
--ssh defaultargument which does a pass-thru of the ssh-agent socket from the host to the builder. This PR defines a new parameterssh_identityand if set, it temporarily spawns anssh-agentduring the docker build.