Skip to content

Without Cubes Background Image #1602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

nadavc-jfrog
Copy link

No description provided.

@jgsogo
Copy link
Contributor

jgsogo commented Mar 18, 2020

Is this the intended output?

image

@nadavc-jfrog
Copy link
Author

nadavc-jfrog commented Mar 18, 2020 via email

@jgsogo
Copy link
Contributor

jgsogo commented Mar 18, 2020

Sorry, there were some cached elements. Is this the correct one?

image

@nadavc-jfrog
Copy link
Author

nadavc-jfrog commented Mar 18, 2020 via email

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • Remove the conan-dec-image adornment
  • Do not add a file that is called conan-logo-old, instead just replace the existing one
  • Update the logo with the new one

Removed old logo
Updated the logo with the new one
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ nadavc-jfrog
❌ ncamaa
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants