[libsndfile] Make libsndio optional to avoid ffmpeg breakage #26050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
danimtb
approved these changes
Nov 27, 2024
|
Take a look at #25543 as well, please. |
OMGtechy
pushed a commit
to OMGtechy/conan-center-index
that referenced
this pull request
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes to recipe: libsndfile/1.2.2
Motivation
The FFMPEG is being affected by the PR #23150, where not libsndio is always required now, but uses ALSA always as well.
First, libsndio only work on Windows, so it makes FFMPEG not possible to be used in Windows. Second, consuming ALSA by default creates a conflict when consuming FFMPEG as well:
Details
The libsndfile has no exported option for sndio, but it's optional:
The libsdnio only has the version 1.9.0 maintained in ConanCenterIndex. The Linter found dead code based on old versions. The code was remove (kudos @perseoGI )