Skip to content

Prepare for auto-powered releases #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 29, 2024
Merged

Prepare for auto-powered releases #113

merged 3 commits into from
Jul 29, 2024

Conversation

asmacdo
Copy link
Member

@asmacdo asmacdo commented Jul 25, 2024

I followed the instructions for a project that is already released: https://intuit.github.io/auto/docs/welcome/getting-started#make-latest-release

Now, it appears to be configured correctly.

./auto info                

Environment Information:

"auto" version: v11.1.5
"git"  version: v2.45.0
"node" version: v16.16.0

Project Information:

✔ Repository:      con/duct
✔ Author Name:     Austin Macdonald
✔ Author Email:    austin@dartmouth.edu
✔ Current Version: v0.0.1
✔ Latest Release:  v0.0.1

✔ Labels configured on GitHub project 

GitHub Token Information:

✔ Token:            [Token starting with ghp_]
✔ Repo Permission:  admin
✔ User:             asmacdo
✔ API:              
✔ Enabled Scopes:   repo, write:packages
✔ Rate Limit:       2862/5000

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.60%. Comparing base (00162cc) to head (8372e7c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #113   +/-   ##
=======================================
  Coverage   93.60%   93.60%           
=======================================
  Files           2        2           
  Lines         344      344           
  Branches       57       57           
=======================================
  Hits          322      322           
  Misses         16       16           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@asmacdo
Copy link
Member Author

asmacdo commented Jul 25, 2024

I've also run auto shipit --dry-run and that looks good. I suppose we merge this, then I'll mark #110 as a "minor" update. (Its actually a breaking change, but I don't want auto to go to 1.0.0). When that merges, hopefully we see the magic!

@asmacdo asmacdo marked this pull request as ready for review July 25, 2024 19:40
@asmacdo asmacdo requested review from jwodder and yarikoptic July 25, 2024 19:40
@jwodder
Copy link
Member

jwodder commented Jul 25, 2024

@asmacdo

  • I see you're using the default auto label names of "major", "minor", and "patch". If you ever enable Dependabot in this repository, this will lead to problems, so you may want to rename the labels to something like "semver-major", "semver-minor", and "semver-patch". See Figure out why major label was added to dependabot created PR datalad/datalad-installer#175 for more information.
  • release.yml is currently configured to only run on workflow dispatch, i.e., manually, rather than when a PR is merged. Is that intentional?
  • .autorc currently sets onlyPublishWithReleaseLabel to true, so releases require a PR to be marked with "release", and the "skip-release" label is unnecessary. Is that intentional?

@asmacdo
Copy link
Member Author

asmacdo commented Jul 25, 2024

ty @jwodder

release.yml is currently configured to only run on workflow dispatch, i.e., manually, rather than when a PR is merged. Is that intentional?

No that was not intentional, good catch.

.autorc currently sets onlyPublishWithReleaseLabel to true, so releases require a PR to be marked with "release", and the "skip-release" label is unnecessary. Is that intentional?

I prefer explicitly ask for a release, I've deleted the skip-release label

I've updated the auto labels to use the semver prefix and https://github.com/con/duct/labels to match

Copy link
Member

@yarikoptic yarikoptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you think it is ready -- fire away and see if works! ;)

@asmacdo asmacdo merged commit 25eb0f3 into con:main Jul 29, 2024
30 checks passed
@asmacdo asmacdo mentioned this pull request Aug 8, 2024
@asmacdo asmacdo deleted the enable-auto branch August 22, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants