-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emit content of unexpected stderr #149
base: master
Are you sure you want to change the base?
Emit content of unexpected stderr #149
Conversation
+ '>>>>>>>>>>>>' | ||
+ cc.ENDC | ||
) | ||
print('IN STDERR WE GOT: %s' % testing_outs['stderr']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this ALLCAPS print statement meant to be kept in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uoops no! that's clearly a leftover. Pushing a fix+rebase shortly
Beside the above comment I am not sure if this makes sense for the general case (I assume this will try to print the full base64 strings if the output is an image?). If you only want this behavior to happen for stream output, then scoping it to that might make sense. |
probably yes
trying to paraphrase what you wrote -- are you saying to restrict this to stdout/stderr (ie we could also add a verbose mode, but I wouldn't know how to do it |
Please note that printing an image as a base64 string will typically output pages upon pages of random characters, completely drowning out any important data. For other data as well, the output will be too large to keep. Maybe outputting the ~70 first characters would make sense (length chosen so line length ends up less than 79 chars, so it fits in default terminal size). |
I came across the |
a5153de
to
5842069
Compare
5842069
to
4c065a5
Compare
Without this patch, I couldn't really understand where the error was coming from -- turned out to be something in stderr emitted by one of our dependencies which recently got an update.
Do you think this can be useful?