Updating minimiser with abstract methods

computationalmodelling · Jul 31, 2024 · d6406e1 · d6406e1
1 parent 6b9931b
commit d6406e1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/fidimag/common/hubert_minimiser.py b/fidimag/common/hubert_minimiser.py
@@ -291,6 +291,7 @@ def minimise(self,
                     if avGradE < mXgradE_tol:
                         print(f'Average torque length |mX∇E|/N = {avGradE} negligible. Stopping calculation.')
                         exitFlag = True
+                        # TODO: add break here?
 
             # Stop while creepCount
 

diff --git a/fidimag/common/minimiser_base.py b/fidimag/common/minimiser_base.py
@@ -1,4 +1,5 @@
 from __future__ import division
+from abc import abstractmethod
 import numpy as np
 import os
 import zipfile
@@ -75,9 +76,8 @@ def run_step_CLIB(self):
         """
         pass
 
-    def minimise(self, stopping_dm=1e-2, max_steps=2000,
-                 save_data_steps=10, save_m_steps=None, save_vtk_steps=None,
-                 log_steps=1000):
+    @abstractmethod
+    def minimise(self):
         pass
 
     def relax(self):