Package type common-webroot #53
Conversation
…st cases for new package configuration.
| if (!empty($extra['installer-paths'])) { | ||
| $customPath = $this->mapCustomInstallPaths($extra['installer-paths'], $prettyName); | ||
| if ($customPath !== false) { | ||
| return $this->templatePath($customPath, $availableVars); | ||
| } | ||
| } | ||
| } elseif ('common-webroot' === $type) { |
There was a problem hiding this comment.
It may be better to implement a hook for installers to validate package configuration instead of adding this into base installer here.
|
Thanks Steve! I'll give this some thought and a look over soon. I really want to implement #43 before moving on this type of thing. Just to make sure installers continues to work appropriately with composer. |
|
I created a separate installer project to cover this case. I intend to have an overlay concept on the roadmap. https://github.com/fancyguy/webroot-installer Not quite sure which approach is better, what is the overall goal of composer/installers? To handle common framework extensions or be a general purpose catch-all installer? |
|
Awesome thanks! I'll direct people there if they are also looking for this use case. I see |
|
Isn't this what http://getcomposer.org/doc/03-cli.md#create-project thanks! |
Proposal for webroot themed packages. In #38 drupal-core places the package in core. This commit exposes a new extra in the inflected vars
{$webroot}that can be used by packages. It forcesinstaller-webrootto be defined on the root package for acommon-webrootpackage.This proposes a package to be defined as a webroot application with a variable webroot location. A way to assert that there is only one package of that type would be ideal, not quite sure how to implement that.