Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support gzipped spectra files #184

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

support gzipped spectra files #184

wants to merge 3 commits into from

Conversation

paretje
Copy link
Contributor

@paretje paretje commented Aug 23, 2024

Use file type check added in compomics/ms2rescore-rs#1 to support any filetype supported by ms2rescore_rs.

Note that the first regex match would always fail, assuming the
extension wasn't the complete filename, so the for loop would always
trigger. The exists check was added instead, and is needed for e.g.
gzipped files when the run name would be without the .gz extension.
ms2rescore/utils.py Show resolved Hide resolved
@RalfG RalfG added the feature new feature label Sep 17, 2024
@RalfG RalfG added this to the v3.2.0 milestone Sep 17, 2024
@RalfG
Copy link
Member

RalfG commented Sep 19, 2024

Waiting to merge for ms2rescore-rs 0.4.0 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants