Enable importance checkbox for admin and participant #1682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ballPointPenguin
force-pushed
the
icpc-rebase
branch
from
4f65ec9
to
e1fcb8e
Compare
ballPointPenguin
changed the title
|
TODO (future):
|
xeeg
reviewed
May 23, 2023
client-admin/src/components/conversation-admin/conversation-config.js
Outdated
Show resolved
Hide resolved
| fill: #8a8a8a; | ||
| " | ||
| data-text="{{s.importantCheckboxDesc}}" | ||
| onclick="alert(this.dataset.text)" |
There was a problem hiding this comment.
Please replace the alert with a tooltip here. on-hover for desktop and on-tap for mobile.
| @@ -330,9 +330,23 @@ | |||
| <div style="text-align: center; margin-bottom: 20px"> | |||
| <label class="weight-label"> | |||
| <span class="weight-radio"></span> | |||
| <input type="checkbox" name="checkbox" id="weight_high"> | |||
| <input type="checkbox" name="checkbox" id="weight_high" aria-describedby="importantCheckboxDesc"> | |||
There was a problem hiding this comment.
Let's move the checkbox above the agree/disagree/pass buttons.
… above the vote buttons
|
@metasoarous could you please catch the "high_priority" field in the export function. |
metasoarous
changed the title
|
@colinmegill Would you please do a design review on the relative positioning of the checkbox & buttons? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
incorporate changes from https://github.com/chena11356/polis/tree/implement-comment-prioritization-checkbox
credit to https://github.com/chena11356
addresses #217
recreated from #1562