Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make psql shell #1627

Open
wants to merge 2 commits into
base: edge
Choose a base branch
from
Open

Make psql shell #1627

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
294aa37
Add psql-shell task to makefile
metasoarous Feb 17, 2023
00739b3
Merge branch 'edge' into make-psql-shell
metasoarous Feb 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,14 +86,18 @@ e2e-run-all: ## Run E2E tests: all
$(E2E_RUN) npm run e2e:all


psql-shell: ## Assuming a system is already running with `make start`, start up an interactive psql shell
docker-compose exec postgres psql --username postgres --dbname polis-dev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ballPointPenguin Should this actually be --db-name polis-$TAG? Not sure how dev gets set, but assuming that's not right for production connections...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should pull DB_NAME from env

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's POSTGRES_DB in env.



# Helpful CLI shortcuts
rbs: start-rebuild

%:
@true

.PHONY: help pull start stop rm-containers rm-volumes rm-images rm-ALL hash start-rebuild restart-FULL-REBUILD \
rm-ALL-ALL-TAGS e2e-install e2e-prepare e2e-run-minimal e2e-run-standalone e2e-run-secret e2e-run-subset e2e-run-all
rm-ALL-ALL-TAGS e2e-install e2e-prepare e2e-run-minimal e2e-run-standalone e2e-run-secret e2e-run-subset e2e-run-all psql-shell

help:
@echo 'Usage: make <command>'
Expand Down