Skip to content

Commit

Permalink
Merge pull request #17 from como-ph/v0.1.1
Browse files Browse the repository at this point in the history
V0.1.1
  • Loading branch information
ernestguevarra authored Aug 8, 2020
2 parents af808de + 5439c3e commit 23eee1a
Show file tree
Hide file tree
Showing 45 changed files with 200 additions and 122 deletions.
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: oxcovid19
Type: Package
Title: An R API to the Oxford COVID-19 Database
Version: 0.1.1.9000
Version: 0.1.1
Authors@R: c(person(given = "Ernest", family = "Guevarra",
email = "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0000-0002-4887-4415")),
Expand Down Expand Up @@ -45,7 +45,7 @@ Suggests:
Encoding: UTF-8
Language: en-gb
LazyData: true
URL: https://github.com/como-ph/oxcovid19, https://como-ph.github.io/oxcovid19
URL: https://github.com/como-ph/oxcovid19
BugReports: https://github.com/como-ph/oxcovid19/issues
RoxygenNote: 7.1.1
VignetteBuilder: knitr
4 changes: 0 additions & 4 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

* Edited 2 marked UTF8 strings

* added `dbplyr` in **Suggests** rather than in **Imports**

* addressed WARNING on CRAN checks

* improved documentation
Expand All @@ -14,8 +12,6 @@

* updated check package GitHub Actions specifications

* added Travis CI for Ubuntu Bionic distribution


# oxcovid19 0.1.0

Expand Down
33 changes: 29 additions & 4 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,30 @@
## Release summary

This is the second release of `oxcovid19`.

This is a release to address warnings and notes identified in [CRAN results](https://cran.r-project.org/web/checks/check_results_oxcovid19.html). In this release:

* I addressed two warnings produced by CRAN checks on macOS:

Warning in engine$weave(file, quiet = quiet, encoding = enc) :
Pandoc (>= 1.12.3) and/or pandoc-citeproc not available. Falling back to R Markdown v1.

Warning in engine$weave(file, quiet = quiet, encoding = enc) :
Pandoc (>= 1.12.3) and/or pandoc-citeproc not available. Falling back to R Markdown v1.

These are the same warnings for two different vignettes. On further investigation, this seems to be related to my generation of figures using Rmarkdown. To address this, I instead generated and saved these figures locally and then inserted the figures into the respective vignettes rather than generating the figures on build.

* I addressed two notes produced by CRAN checks on linux fedora clang and gcc:

Note: found 2 marked UTF-8 strings

Namespace in Imports field not imported from: ‘dbplyr’
All declared Imports should be used.

I found the two marked UTF-8 strings and have edited them accordingly

I do not directly use `dbplyr` in my functions but I use the `tbl` function in `dplyr` that when used with a database connection requires `dbplyr`

## Test environments
* local R installation, R 4.0.2
* ubuntu 16.04 (on github actions), R 4.0.2
Expand All @@ -10,9 +37,7 @@

### For all checks, the results showed:

0 errors | 0 warnings | 1 note

* This is a new release.
0 errors | 0 warnings | 0 note

### For rhub checks, additional resuls showed:

Expand All @@ -24,4 +49,4 @@ Possibly mis-spelled words in DESCRIPTION:

## Reverse dependencies

This is a new release, so there are no reverse/downstream dependencies.
This package has no reverse/downstream dependencies.
2 changes: 1 addition & 1 deletion docs/404.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/LICENSE.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 21 additions & 21 deletions docs/articles/database_access.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/articles/index.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 21 additions & 21 deletions docs/articles/oxcovid19.html

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 23eee1a

Please sign in to comment.