tools.func: remove output suppression for messages #5072
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Description
Several
msg_info
andmsg_ok
messages were suppressed by$STD
in this function. I noticed it when I was using it to install Ruby. I don't know if this was simply missed or if there is a reason for it, so please let me know if it was intentional.make
command would produce output so I added$STD
there.In Prerequisites below, tested thoroughly is unchecked because I have only tested the Ruby install to ensure it still works. Although I don't forsee an issue, I'm thinking that for such a change, you may want me to verify by doing a test run for each function. That's why it's a draft.
🔗 Related PR / Issue
Link: #
✅ Prerequisites (X in brackets)
🛠️ Type of Change (X in brackets)
README
,AppName.md
,CONTRIBUTING.md
, or other docs.