Skip to content

tools.func: remove output suppression for messages #5072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vhsdream
Copy link
Member

@vhsdream vhsdream commented Jun 9, 2025

✍️ Description

Several msg_info and msg_ok messages were suppressed by $STD in this function. I noticed it when I was using it to install Ruby. I don't know if this was simply missed or if there is a reason for it, so please let me know if it was intentional.

  • In the Ruby install function the make command would produce output so I added $STD there.

In Prerequisites below, tested thoroughly is unchecked because I have only tested the Ruby install to ensure it still works. Although I don't forsee an issue, I'm thinking that for such a change, you may want me to verify by doing a test run for each function. That's why it's a draft.

🔗 Related PR / Issue

Link: #

✅ Prerequisites (X in brackets)

  • Self-review completed – Code follows project standards.
  • Tested thoroughly – Changes work as expected.
  • No security risks – No hardcoded secrets, unnecessary privilege escalations, or permission issues.

🛠️ Type of Change (X in brackets)

  • 🐞 Bug fix – Resolves an issue without breaking functionality.
  • New feature – Adds new, non-breaking functionality.
  • 💥 Breaking change – Alters existing functionality in a way that may require updates.
  • 🆕 New script – A fully functional and tested script or script set.
  • 🌍 Website update – Changes to website-related JSON files or metadata.
  • 🔧 Refactoring / Code Cleanup – Improves readability or maintainability without changing functionality.
  • 📝 Documentation update – Changes to README, AppName.md, CONTRIBUTING.md, or other docs.

@github-actions github-actions bot added core maintenance Code maintenance or general upkeep of the project update script A change that updates a script labels Jun 9, 2025
@tremor021
Copy link
Member

That file is all @MickLesk , i've added only the part with ssl certs.

@MickLesk
Copy link
Member

MickLesk commented Jun 9, 2025

I originally added a lot of STDs so that the install process would not be extremely bloated, but that they would only be displayed completely in Verbose. In the dev there is still a msg_custom that should be used for this, but I will generally check all 1000+ lines again and remove a few more msg's. The problem with this function is that the spinner is always running.

At the moment I'm still thinking about removing the spinner in general, and just displaying an hourglass in front of it, makes the process easier and faster and saves resources in error handling.

@vhsdream vhsdream closed this Jun 18, 2025
@vhsdream vhsdream deleted the tools branch June 18, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core maintenance Code maintenance or general upkeep of the project update script A change that updates a script
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants