[commonware-utils] move Array to utils #513
Conversation
roberto-bayardo
force-pushed
the
move-array
branch
from
10b6cd6 to
29b7f21
Compare
roberto-bayardo
changed the title
roberto-bayardo
force-pushed
the
move-array
branch
from
29b7f21 to
ec11f51
Compare
| fn test_validate_invalid_public_key<C: Scheme>() { | ||
| fn test_validate_invalid_public_key<C: Scheme>() | ||
| where | ||
| C::PublicKey: TryFrom<Vec<u8>, Error = Error>, |
There was a problem hiding this comment.
I think this should be unnecessary 🤔
There was a problem hiding this comment.
If it is necessary, I wonder if we can make it not so.
utils/src/lib.rs
Outdated
| @@ -4,7 +4,7 @@ use prost::{encode_length_delimiter, length_delimiter_len}; | |||
|
|
|||
| mod time; | |||
| pub use time::SystemTimeExt; | |||
| pub mod array; | |||
| mod array; | |||
There was a problem hiding this comment.
We'll need to export the error as well if we do this (which might be annoying).
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #513 +/- ##
==========================================
+ Coverage 94.35% 94.37% +0.02%
==========================================
Files 109 110 +1
Lines 30286 30287 +1
==========================================
+ Hits 28575 28584 +9
+ Misses 1711 1703 -8
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
No description provided.