Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use futures::Pool in broadcast::linked #500

Open
wants to merge 5 commits into
base: bc/res
Choose a base branch
from

Conversation

BrendanChou
Copy link
Collaborator

No description provided.

@BrendanChou BrendanChou force-pushed the bc/broadcast-futures-pool branch from 540a924 to e2589b9 Compare February 18, 2025 00:17
Copy link

codecov bot commented Feb 18, 2025

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.72%. Comparing base (2c0b42e) to head (e2589b9).

Files with missing lines Patch % Lines
broadcast/src/linked/signer/actor.rs 80.00% 2 Missing ⚠️
@@            Coverage Diff             @@
##           bc/res     #500      +/-   ##
==========================================
+ Coverage   93.68%   93.72%   +0.03%     
==========================================
  Files         112      112              
  Lines       30437    30424      -13     
==========================================
- Hits        28515    28514       -1     
+ Misses       1922     1910      -12     
Files with missing lines Coverage Δ
broadcast/src/linked/mod.rs 99.26% <100.00%> (ø)
broadcast/src/linked/signer/actor.rs 90.12% <80.00%> (-0.41%) ⬇️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c0b42e...e2589b9. Read the comment docs.

@BrendanChou BrendanChou force-pushed the bc/res branch 2 times, most recently from 7099aa7 to 96420ed Compare February 22, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant