chore: fix argument type in bytes method call in build.rs #368
Conversation
| fn main() -> Result<()> { | ||
| // Proto compilation rules for `simplex` dialect | ||
| let mut config = prost_build::Config::new(); | ||
| config.bytes([ | ||
| config.bytes(&[ |
There was a problem hiding this comment.
While this isn't a fix per se (it works fine), their examples do definitely use & and find it worth mirroring their style: https://docs.rs/prost-build/latest/prost_build/struct.Config.html#method.bytes
Would you mind making this change to all build.rs files (I'd like to do all at once).
|
Would you mind rebasing this? |
Thank you for the feedback! I completely agree that it’s worth mirroring the style used in the official examples for consistency. I’ll update the PR to apply this change across all build.rs files to ensure uniformity. I’ll make the adjustments and push the changes shortly. Let me know if there’s anything else you’d like me to address! |
|
patrick-ogrady please check and merge. |
The
bytesmethod was being called with an array of strings[&str; N], but it actually expects a slice of strings&[&str]. I've fixed this by adding a&before the array.This ensures the correct type is passed and avoids any potential issues.