[runtime/network] poison sink/stream on error and cancellation#3501
Open
andresilva wants to merge 13 commits intomainfrom
Open
[runtime/network] poison sink/stream on error and cancellation#3501andresilva wants to merge 13 commits intomainfrom
andresilva wants to merge 13 commits intomainfrom
Conversation
Deploying monorepo with
|
| Latest commit: |
b9a1b69
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://41a8e909.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://andre-runtime-network-poison.monorepo-eu0.pages.dev |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | b9a1b69 | Apr 03 2026, 01:49 PM |
5a7a281 to
3481b97
Compare
Merged
Codecov Report❌ Patch coverage is @@ Coverage Diff @@
## main #3501 +/- ##
==========================================
- Coverage 95.74% 95.73% -0.01%
==========================================
Files 438 438
Lines 157975 158264 +289
Branches 3706 3722 +16
==========================================
+ Hits 151249 151517 +268
- Misses 5541 5562 +21
Partials 1185 1185
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the network
Sink/Streamcontract so each half is poisoned after cancellation or its first I/O error instead of being implicitly reusable in an incosistent state. A failedsendnow makes theSinkunusable, and a failedrecvmakes theStreamunusable, subsequent operations on that same half returnClosed, while the opposite direction can still continue.Related #2596 (possibly closes it?)