Conversation
This lets us pre-verify easily.
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | f85722d | Mar 06 2026, 11:16 PM |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Deploying monorepo with
|
| Latest commit: |
f85722d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://540a7e0d.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://ck-dkg-finalize-opts.monorepo-eu0.pages.dev |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| } | ||
| let selection = logs | ||
| .clone() | ||
| .select::<ed25519::Batch>(&info, &mut rng, &Sequential); |
There was a problem hiding this comment.
Shared mutable RNG across test assertions may cause nondeterminism
Low Severity
The test's rng is now mutably shared across select, observe, and multiple finalize calls in a loop. Each call consumes RNG state for batch verification, changing downstream randomness. Previously, select and observe didn't take &mut rng, so the RNG stream was unaffected. Now, the number of RNG draws varies depending on the number of dealers/reveals, making the test's determinism fragile — future changes to batch verification internals could shift the RNG state and alter subsequent test behavior.
Additional Locations (2)
There was a problem hiding this comment.
It's still deterministic though, even if "fragile" which is fine, it's random.
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## ck/lin_comb_eval #3328 +/- ##
====================================================
- Coverage 93.03% 93.03% -0.01%
====================================================
Files 418 418
Lines 143564 143686 +122
Branches 3435 3442 +7
====================================================
+ Hits 133571 133682 +111
- Misses 8900 8907 +7
- Partials 1093 1097 +4
... and 7 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
1 participant
Stacked on top of #3312.
Closes #2536.
Closes #3212.
This adds a new structure for containing dealer logs, allowing them to be verified in advance.
We also implement optimizations for a given dealer, batching signature checks, and reveal checks.
One big win is implementing parallelism to check multiple dealers at once (while preserving the order we select dealers in), which allows the method to actually scale, whereas it was bottlenecked previously.