Conversation
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
commonware-mcp | 6eca4cb | Mar 06 2026, 09:23 PM |
consensus/src/simplex/mod.rs
Outdated
| //! * On failure: set `t_l` to `0` | ||
| //! | ||
| //! Upon receiving `2f+1` `nullify(v)`: | ||
| //! * Set `t_r` to `None` |
There was a problem hiding this comment.
missing line where you set t_r?
There was a problem hiding this comment.
in
monorepo/consensus/src/simplex/mod.rs
Line 78 in 7251e48
and in
monorepo/consensus/src/simplex/mod.rs
Line 82 in 7251e48
consensus/src/simplex/mod.rs
Outdated
| //! * Broadcast `nullify(v)` | ||
| //! * Every `t_r` after `nullify(v)` broadcast that we are still in view `v`: | ||
| //! * Rebroadcast `nullify(v)` and either `notarization(v-1)` or `nullification(v-1)` | ||
| //! * If `nullify(v)` has not yet been broadcast, broadcast `nullify(v)` and set `t_r` to `now+T` // TODO: define `T` |
There was a problem hiding this comment.
That is the question. What is T? The original Simplex does not have that constant in terms of Δ. In the code it is user defined
Deploying monorepo with
|
| Latest commit: |
6eca4cb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://46745ee3.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://denis-simplex-informal.monorepo-eu0.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3300 +/- ##
==========================================
+ Coverage 92.99% 93.03% +0.04%
==========================================
Files 418 418
Lines 141987 143544 +1557
Branches 3393 3434 +41
==========================================
+ Hits 132041 133550 +1509
- Misses 8855 8901 +46
- Partials 1091 1093 +2
... and 40 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
2 participants
This PR is a starting point for resolving #3299.