[collector] track commitments only after successful send#3290
Open
sashass1315 wants to merge 1 commit intocommonwarexyz:mainfrom
Open
[collector] track commitments only after successful send#3290sashass1315 wants to merge 1 commit intocommonwarexyz:mainfrom
sashass1315 wants to merge 1 commit intocommonwarexyz:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
collector::p2p::Engine was creating a tracked commitment before network send completed.
If send failed (or returned no recipients), the commitment could remain in
trackedwithout any real outbound request, which caused stale state and inaccurateoutstandingtracking until manual cancel.Move commitment tracking to the successful send path and only track when at least one recipient was actually sent to.
This prevents stale tracked entries on send errors/empty recipient results while preserving existing behavior for valid sends.