[deployer]: remove unbounded layered S3 retries#3279
Open
GarmashAlex wants to merge 1 commit intocommonwarexyz:mainfrom
Open
[deployer]: remove unbounded layered S3 retries#3279GarmashAlex wants to merge 1 commit intocommonwarexyz:mainfrom
GarmashAlex wants to merge 1 commit intocommonwarexyz:mainfrom
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| .await | ||
| .map_err(|e| Error::AwsS3 { | ||
| bucket: bucket.to_string(), | ||
| operation: super::S3Operation::HeadObject, |
There was a problem hiding this comment.
Wrong S3Operation variant used for PutObject error
Medium Severity
The upload_with_retry function performs a put_object call but tags the error with S3Operation::HeadObject. This causes any upload failure to be reported as a HeadObject error, making it very difficult to diagnose S3 upload issues. The S3Operation enum also lacks a PutObject variant, so one needs to be added.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Why were these changes needed?
S3 uploads had two unbounded retry layers at the same time:
with_max_attempts(u32::MAX),This made failures hard to diagnose and could cause very long or effectively unbounded wait times.
What does this change do?
max_attempts = 5).