[runtime] Tree-Structured Context (Remove Detached)
#1867
+483
−249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrick-ogrady
commented
Oct 13, 2025
patrick-ogrady
commented
Oct 13, 2025
patrick-ogrady
commented
Oct 13, 2025
patrick-ogrady
commented
Oct 13, 2025
Deploying monorepo with
|
| Latest commit: |
7db779d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8dd427b6.monorepo-eu0.pages.dev |
| Branch Preview URL: | https://children-cleanup.monorepo-eu0.pages.dev |
patrick-ogrady
changed the title
Detached)
patrick-ogrady
commented
Oct 14, 2025
| }); | ||
| } | ||
|
|
||
| fn test_supervision_tree_sparse_clone_chain<R: Runner>(runner: R) |
There was a problem hiding this comment.
nit: remove supervision from the test names
patrick-ogrady
commented
Oct 14, 2025
| /// Metric label describing whether a task runs on a dedicated thread. | ||
| #[derive(Clone, Debug, Hash, PartialEq, Eq, EncodeLabelValue)] | ||
| pub enum Mode { | ||
| pub enum Execution { |
There was a problem hiding this comment.
nit: improve the naming here
patrick-ogrady
commented
Oct 14, 2025
| /// registers a new child node beneath the current node, while spawning a task transfers ownership | ||
| /// of that node to the spawned task. When a context finishes or is aborted, the runtime drains the | ||
| /// node and aborts all descendant tasks. | ||
| pub(crate) struct SupervisionTree { |
There was a problem hiding this comment.
nit: improve the naming here
patrick-ogrady
commented
Oct 14, 2025
|
|
||
| fn register_child(&mut self, child: &Arc<SupervisionTree>) { | ||
| // To avoid unbounded growth of children for clone-heavy loops, we reap dropped children here. | ||
| self.children.retain(|weak| weak.strong_count() > 0); |
There was a problem hiding this comment.
This avoid the child ever needing to interact with the parent (which may cause a deadlock from mutex cycle)
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1867 +/- ##
==========================================
+ Coverage 92.10% 92.22% +0.11%
==========================================
Files 307 309 +2
Lines 79643 81447 +1804
==========================================
+ Hits 73357 75115 +1758
- Misses 6286 6332 +46
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1833
Previous: #1850
Blocking: #1884
TODO
supervision.rs