[storage] Move MMR size check to Position; validate size in extract_pinned_nodes

[danlaine]

This PR will resolve #1713.

[cloudflare-workers-and-pages]

Deploying monorepo with    Cloudflare Pages

Latest commit:	e0b9bc1
Status:	✅  Deploy successful!
Preview URL:	https://63a647e0.monorepo-eu0.pages.dev
Branch Preview URL:	https://danlaine-validate-position.monorepo-eu0.pages.dev

View logs

[roberto-bayardo]

Are you also going to remove the panic from Location::try_from?

[danlaine]

Are you also going to remove the panic from Location::try_from?

I'll make I made a separate PR for that

[codecov]

Codecov Report

❌ Patch coverage is 95.55556% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.10%. Comparing base (9c7abdc) to head (e0b9bc1).

Files with missing lines	Patch %	Lines
storage/src/mmr/position.rs	96.42%	1 Missing ⚠️
storage/src/mmr/proof.rs	83.33%	1 Missing ⚠️

@@            Coverage Diff             @@
##             main    #1857      +/-   ##
==========================================
- Coverage   92.10%   92.10%   -0.01%     
==========================================
  Files         307      307              
  Lines       79648    79649       +1     
==========================================
- Hits        73362    73361       -1     
- Misses       6286     6288       +2     

Files with missing lines	Coverage Δ
storage/src/mmr/iterator.rs	97.90% <100.00%> (-0.37%)	⬇️
storage/src/mmr/journaled.rs	98.50% <100.00%> (ø)
storage/src/mmr/mem.rs	91.84% <100.00%> (ø)
storage/src/mmr/position.rs	92.30% <96.42%> (+0.81%)	⬆️
storage/src/mmr/proof.rs	94.87% <83.33%> (-0.09%)	⬇️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c7abdc...e0b9bc1. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.