-
Notifications
You must be signed in to change notification settings - Fork 111
[storage/adb/current] adb::ordered::current (provides exclusion proof support) #1799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Deploying monorepo with
|
Latest commit: |
ca42d14
|
Status: | ✅ Deploy successful! |
Preview URL: | https://131b5e26.monorepo-eu0.pages.dev |
Branch Preview URL: | https://exclusion-proof-db.monorepo-eu0.pages.dev |
daced5e
to
5ba7fc9
Compare
c05e8b7
to
0f4496f
Compare
264d8d8
to
475173b
Compare
51d13da
to
c2aff73
Compare
2f0cbcb
to
49a8525
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces an ordered variant of the current authenticated database (ADB) that supports key exclusion proofs. The main purpose is to extend the existing unordered current ADB implementation with ordered key capabilities, allowing users to prove that specific keys do not exist in the database.
Key changes include:
- Creation of a new
adb::current::ordered
module with exclusion proof functionality - Refactoring of the existing current ADB to separate ordered and unordered variants
- Addition of helper methods for empty MMR root computation and ordered key operations
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
storage/src/mmr/mem.rs | Added empty_mmr_root helper method and corresponding test |
storage/src/mmr/hasher.rs | Updated test to use new empty MMR root helper |
storage/src/mmr/grafting.rs | Fixed documentation reference from specific type to module |
storage/src/adb/mod.rs | Added KeyExists error variant for exclusion proof failures |
storage/src/adb/current/unordered.rs | Updated to use new shared verification function and added next_key field |
storage/src/adb/current/ordered.rs | New implementation of ordered current ADB with exclusion proof support |
storage/src/adb/current/mod.rs | Refactored to support both ordered and unordered variants, added shared verification functions |
storage/src/adb/benches/current_init.rs | Updated import to use unordered variant |
storage/src/adb/any/fixed/unordered.rs | Added is_empty helper method |
storage/src/adb/any/fixed/ordered.rs | Made fields and methods public for use by current ordered implementation |
storage/fuzz/fuzz_targets/adb_current_operations.rs | Updated import to use unordered variant |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
storage/src/adb/current/ordered.rs
Outdated
// Handle the case where the proof shows the db is empty, hence any key is proven | ||
// excluded. | ||
let op = Operation::<K, V>::CommitFloor(loc); | ||
// Make sure the |
Copilot
AI
Oct 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incomplete comment on line 657. The comment 'Make sure the' appears to be cut off and should be completed or removed.
// Make sure the |
Copilot uses AI. Check for mistakes.
49a8525
to
ca42d14
Compare
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1799 +/- ##
==========================================
+ Coverage 92.21% 92.27% +0.05%
==========================================
Files 308 309 +1
Lines 81255 82320 +1065
==========================================
+ Hits 74931 75960 +1029
- Misses 6324 6360 +36
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
This PR creates a variant of adb::current called adb::ordered::Current that supports key exclusion proofs.
TODO: