Skip to content

Conversation

syrupipy
Copy link
Contributor

@syrupipy syrupipy commented Oct 3, 2025

Closes #1783 by normalizing metric labels to replace '-' with '_' for Prometheus compatibility.

Copy link
Contributor

@patrick-ogrady patrick-ogrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test for this?

I'm still sorting out whether we want to normalize or panic.

@syrupipy
Copy link
Contributor Author

syrupipy commented Oct 3, 2025

Can you add a test for this?

Sure added now

Copy link

codecov bot commented Oct 6, 2025

Codecov Report

❌ Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.17%. Comparing base (33a3a75) to head (9a2a9db).
⚠️ Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
runtime/src/lib.rs 95.65% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #1785      +/-   ##
==========================================
+ Coverage   92.16%   92.17%   +0.01%     
==========================================
  Files         302      302              
  Lines       77817    77840      +23     
==========================================
+ Hits        71722    71751      +29     
+ Misses       6095     6089       -6     
Files with missing lines Coverage Δ
runtime/src/deterministic.rs 96.80% <100.00%> (+<0.01%) ⬆️
runtime/src/tokio/runtime.rs 84.04% <100.00%> (+0.04%) ⬆️
runtime/src/lib.rs 97.54% <95.65%> (+0.56%) ⬆️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a3a75...9a2a9db. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[runtime] Prevent Labels with -

2 participants