Skip to content

Conversation

BrendanChou
Copy link
Collaborator

@BrendanChou BrendanChou commented Sep 25, 2025

Fixes #1706

TODO: tests

@BrendanChou BrendanChou force-pushed the bc/1706-marshal-sync-height branch from 1c22518 to 45c6a23 Compare September 25, 2025 00:30
Copy link

codecov bot commented Sep 25, 2025

Codecov Report

❌ Patch coverage is 78.94737% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.09%. Comparing base (7a66af6) to head (45c6a23).

Files with missing lines Patch % Lines
consensus/src/marshal/finalizer.rs 72.72% 3 Missing ⚠️
consensus/src/marshal/actor.rs 85.71% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main    #1707      +/-   ##
==========================================
- Coverage   92.10%   92.09%   -0.01%     
==========================================
  Files         297      297              
  Lines       75500    75516      +16     
==========================================
+ Hits        69538    69550      +12     
- Misses       5962     5966       +4     
Files with missing lines Coverage Δ
consensus/src/marshal/mod.rs 99.75% <100.00%> (ø)
consensus/src/marshal/actor.rs 87.04% <85.71%> (-0.06%) ⬇️
consensus/src/marshal/finalizer.rs 85.18% <72.72%> (-3.46%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a66af6...45c6a23. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

}
}
Orchestration::Repair { height } => {
// While this should never happen, if the height is less than the sync
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be sure we cancel all resolution requests if we allow the sync target to update dynamically (or track height + digest).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

[marshal] Allow starting from state-sync

2 participants