Skip to content

feat(storage): add Position and Location types for MMR nodes #1679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(storage): add Position and Location types for MMR nodes #1679

wants to merge 3 commits into from

Conversation

DeVikingMark
Copy link

Summary

Adds type-safe Position and Location wrappers to distinguish between MMR node positions and leaf locations, preventing common usage errors.

Changes

  • New types: Position (node index in MMR) and Location (leaf index in leaf list)
  • Conversion functions: position_to_location() and location_to_position()
  • Ergonomic features: From/Into conversions, arithmetic ops, Display trait
  • Backward compatibility: Existing leaf_num_to_pos/leaf_pos_to_num functions unchanged

Testing

  • 6 new comprehensive tests for types module
  • All 69 existing MMR tests pass
  • Verified position/location mapping correctness

Fixes #1673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[storage] Add position and location types

1 participant

@DeVikingMark