-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add scope selector #118
base: master
Are you sure you want to change the base?
Add scope selector #118
Conversation
any idea when this will be available? i'd like to configure custom scopes |
me too !! it would be great ! |
Hi, when this will be available? We're waiting for this too. |
Hi @jimthedev, can we have a review for this ? |
@bertho-zero oh, neat, you've been working on this as well; I didn't know about |
@bertho-zero just pushed my own version of this in #126, which tries to achieve the same goal in a cleaner manner (I didn't realise you already had this PR when I started writing my version), also means there's no double-prompt run. it's fairly similar but allows users to also specify their own scope, so is less strict than your implementation. I think we could add a "don't allow free scope" option too if you wanna be really strict about scopes choices. Perhaps |
Yes, this option can be useful if the commitlint config uses the |
@bertho-zero Okay, so, I think if scope-enum is set, given that behaviour, then CZ_SCOPES_STRICT is implied — I could probably update my branch to implement that behaviour. I'm not sure if you've had a chance to take a look at my implementation, but I've effectively separated configuration from the running of the engine, such that we can test the parsing of configuration in isolation Still need to write tests for the flow of inputs through that though! |
Any news? |
who's in charge of this repo? how can we get this merged? |
@btd1337 @nweajoseph I haven't had a chance to ever look at this branch again, due to a lack of time. Maybe you could contribute unit tests to the code over at #126 and rebase it? More than happy to let someone else see it to completion. |
I am really looking forward to this feature |
Is it possible to get this simple feature merged ? If you are a project maintainer you should be able to allow only a limited scope to ensure consistency accros commit messages. |
…log into scope-enum
…hangelog into scope-enum
I tried to test the feature but did not get prompted with the scopes. what am I missing? @bertho-zero "cz-conventional-changelog": "bertho-zero/cz-conventional-changelog#scope-enum", I configured in package.json "config": {
"commitizen": {
"path": "cz-conventional-changelog",
"allowedScopes": [
"my-project1",
"my-project2",
"my-project3"
]
}
}, |
I found a nice alternative to cz-conventional-changelog that can even autodetect the scopes if you work in a monorepo: https://github.com/Zhengqbbb/cz-git |
No description provided.