Skip to content

Restore branch #1512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 59 commits into from
Closed

Restore branch #1512

wants to merge 59 commits into from

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Jun 8, 2025 •
edited
Loading

Description

What I did is basically

git fetch origin 5a83aebeeed2dbd9a1284b94d5402bb426e70620
git checkout -b restore-old-branch 5a83aeb
git rebase -i upstream/master
git rebase --skip
git rebase --skip
git rebase --skip

bearomorphism and others added 26 commits June 8, 2025 18:05
@bearomorphism
refactor: improve readability and fix typos
4fccd3d
@bearomorphism
refactor(version_scheme): cleanup
ec1f894
@bearomorphism
refactor(commit): simplify call
271d4f0
@bearomorphism
test(commit): when nothing is added to commit
a9f0f9c
@bearomorphism
refactor(git): code cleanup and better test coverage
e939217
@bearomorphism
test(git): add test for from_rev_and_commit
1fe47d8
@bearomorphism
docs(git): from_rev_and_commit docstring
1a029c5
@bearomorphism
refactor(EOLType): add eol enum back and reorganize methods
6e79848
@bearomorphism
refactor(git): refactor get_tag_names
b62867d
@bearomorphism
refactor(changelog): minor cleanup
f602aa8
@bearomorphism
refactor(BaseConfig): use setter
326325f
@bearomorphism
refactor(bump): add type for out, replace function with re escape
940e705
@bearomorphism
refactor(bump): clean up
1cf91b3
@bearomorphism
test(bump): improve test coverage
aaf9da8
@bearomorphism
fix(defaults): add non-capitalized default constants back and depreca…
f7ae081 
…ted warning

relates commitizen-tools#1446
@bearomorphism
refactor: misc cleanup
1c213da
@bearomorphism
refactor(git): extract _create_commit_cmd_string
abf1197
@bearomorphism
test(test_git): mock os
9293cdc
@bearomorphism
refactor(cli): early return and improve test coverage
d8630ce
@bearomorphism
refactor(changelog): better typing, yield
26e7ab5
@gbaian10 @bearomorphism
refactor(mypy): remove unused-ignore
cf93a88
@gbaian10 @bearomorphism
refactor(cli.py): add type hints
db43f44
@gbaian10 @bearomorphism
refactor: add comment clarifying no_raise parsing to list[int]
3c70f0c
@gbaian10 @bearomorphism
refactor: remove TypeError handling since Python >=3.9 is required
6c281e5 
Since the project requires Python >=3.9, argparse only raises SystemExit
when non-existent commands are provided, making TypeError handling unnecessary.
@bearomorphism
fix(deprecated): mark deprecate in v5
a315248
@gbaian10 @bearomorphism
style(ruff): resolve F401
6c3b69e
@bearomorphism
refactor: make methods protected, better type
2c0a966
@bearomorphism
style: type untyped methods
e1cfe8b
@bearomorphism
style: remove Union
114d01f
@bearomorphism
style: better type
db200c2
@bearomorphism
style: add -> None to __init__
bc937a4
@bearomorphism
build(ruff,mypy): more strict rules
75f26e9
@bearomorphism
fix(BaseConfig): mypy error
15e28c8
@bearomorphism
build(mypy): remove disallow_untyped_defs because it's already done b…
573e77b 
…y ruff rules
@bearomorphism
refactor(bump): TypedDict for bump argument
fd89855
@bearomorphism
refactor(changelog): type untyped arguments
a78a084
@bearomorphism
refactor(check): remove unused argument
ac95cdb
@bearomorphism
style(bump): rename class for consistency
27ab008
@bearomorphism
refactor(check): type CheckArgs arguments
31abd01
@bearomorphism
refactor(commit): type commit args
b3dfd46
@bearomorphism
refactor(commands): remove unused args, type version command args
e70814e
@bearomorphism
style(cli): shorten arg type
8ee1ebf
@bearomorphism
docs(bump): comment on a stupid looking pattern
fa45cc1
@bearomorphism
fix(Check): make parameters backward compatiable
cbf4520
@bearomorphism
style(changelog): rename parameter for consistency
2c4a930
@bearomorphism
refactor(bump): improve readability and still bypass mypy check
01531a4
@bearomorphism
refactor: remove unnecessary bool() and remove Any type from TypedDic…
e5938cd 
…t get
@bearomorphism
style(changelog): add TODO to fixable type ignores
403cfca
@bearomorphism
style(cli): more specific type ignore
c941c4f
@bearomorphism
style(cli): rename kwarg to values
6cc9c89
@bearomorphism
refactor(bump): use any to replace 'or' chain
9a8f3bf
@bearomorphism
perf(bump): avoid unnecessary list construction and rename variable t…
89d9221 
…o avoid confusion
@bearomorphism bearomorphism marked this pull request as draft June 8, 2025 10:09
@bearomorphism bearomorphism deleted the restore-old-branch branch June 12, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woile woile Awaiting requested review from woile

@Lee-W Lee-W Awaiting requested review from Lee-W

@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Assignees
No one assigned
Labels
pr-status: wait-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bearomorphism @gbaian10