Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update percy to v1.1 #2596

Merged
merged 2 commits into from
May 9, 2022
Merged

chore: update percy to v1.1 #2596

merged 2 commits into from
May 9, 2022

Conversation

emmenko
Copy link
Member

@emmenko emmenko commented May 9, 2022

Extracting Percy dep updates from #2555

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9f6e02e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 9, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
merchant-center-application-kit ✅ Ready (Inspect) Visit Preview May 9, 2022 at 10:11AM (UTC)

emmenko
emmenko commented May 9, 2022
View reviewed changes
.github/renovate.json
Comment on lines +33 to +36
{
"matchPackageNames": ["@percy/puppeteer"],
"allowedVersions": "<=2.0.0"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See related issue for Jest/ESM support, which was added to @percy/puppeteer on v2.0.1.

percy/percy-puppeteer#426

For now, we downgrade to v2.0.0.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to link things together, we needed to do the same in ui-kit.

emmenko
emmenko commented May 9, 2022
View reviewed changes
jest-puppeteer.config.js
@@ -7,5 +7,6 @@ module.exports = {
command: 'yarn visual-testing-app:preview',
port: 3000,
launchTimeout: 10000,
debug: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To help debugging issues on CI.

@emmenko emmenko requested a review from a team May 9, 2022 10:06
@vercel vercel bot temporarily deployed to Preview May 9, 2022 10:11 Inactive
CarlosCortizasCT
CarlosCortizasCT approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@CarlosCortizasCT CarlosCortizasCT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@emmenko emmenko merged commit a5c26f2 into main May 9, 2022
@emmenko emmenko deleted the nm-percy-v1.1 branch May 9, 2022 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdeekens tdeekens tdeekens approved these changes

@Rhotimee Rhotimee Rhotimee approved these changes

@CarlosCortizasCT CarlosCortizasCT CarlosCortizasCT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@emmenko @tdeekens @Rhotimee @CarlosCortizasCT