Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update upload-artifact@v3 to v4 as recommended by github. #702

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

michael-odonovan
Copy link
Contributor

@michael-odonovan michael-odonovan commented Jan 30, 2025

Update upload-artifact@v3 to v4 as recommended by github.

Came up as a fix for this error when merging recent branch into master:
https://github.com/comicrelief/component-library/actions/runs/13055051495/job/36423927479

Screenshot 2025-01-30 at 5 05 05 PM

Notice from github:
https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

@michael-odonovan michael-odonovan self-assigned this Jan 30, 2025
@michael-odonovan michael-odonovan changed the title fix: upload artifact action yaml fix: update artifact action version in yaml Jan 30, 2025
@michael-odonovan michael-odonovan changed the title fix: update artifact action version in yaml fix: update upload-artifact@v3 to v4 as recommended by github. Jan 30, 2025
@AndyEPhipps
Copy link
Contributor

Hm, looks like you didn't start this branch from master? Seeing lots of commits from your other branch

@michael-odonovan michael-odonovan force-pushed the fix_upload_artifact_action_yaml branch from ecfcc26 to 2de06c4 Compare January 31, 2025 09:19
@michael-odonovan michael-odonovan merged commit f1bc8f8 into master Jan 31, 2025
9 checks passed
@michael-odonovan michael-odonovan deleted the fix_upload_artifact_action_yaml branch January 31, 2025 09:27
Copy link

🎉 This PR is included in version 8.13.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants