-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add more props to Checkbox for Donate styling #697
feat: add more props to Checkbox for Donate styling #697
Conversation
…rary into df_191_more_props_Checkbox_for_styling
As per Slack conversation, I did try importing this branch / commit into CR.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…rary into df_191_more_props_Checkbox_for_styling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AndyEPhipps
Is this right or should I change to something else? |
Ah shit, I'm sorry, my bad - I somehow missed that you'd added prop options for ALL of these colour-usages; so that green border in the example was by design 👍 Just testing a few things locally, sec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, sorry about the misunderstanding
Nah man I was sloppy earlier sorry |
🎉 This PR is included in version 8.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
PR Titles
To pass testing pipeline, these need to follow Conventional Commits spec:
https://www.conventionalcommits.org/en/v1.0.0/
e.g.
feat: create NewForm component
or
fix: update broken link in NewForm component
PR description
What is it doing?
feat: add more props to Checkbox for Donate styling
Why is this required?
Donate styling work.
link to Jira ticket:
https://comicrelief.atlassian.net/browse/DF-191
Quick Checklist:
My PR title follows the Conventional Commit spec.
I have filled out the PR description as per the template above.
I have added tests to cover new or changed behaviour.
I have updated any relevant documentation.
Important! - lastly, make sure to squash merge...